Used the kmeta.ChildName() to generate OIDC service account name

[MeenuyD]

Refactor OIDC service account naming in GetOIDCServiceAccountNameForResource

This updates the method GetOIDCServiceAccountNameForResource in eventing/pkg/auth/serviceaccount.go to refactor the way OIDC service account names are generated. Instead of combining Group/Kind and the name of the parent object directly, it now uses kmeta.ChildName to generate the service account names. This change is made to prevent names from exceeding the maximum allowed length.
#7470

[knative-prow]

Hi @MeenuyD. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/ok-to-test

[Cali0707]

Hey @MeenuyD it looks like the serviceaccount unit tests are failing:

--- FAIL: TestGetOIDCServiceAccountNameForResource (0.00s)
    --- FAIL: TestGetOIDCServiceAccountNameForResource/should_return_SA_name_in_correct_format (0.00s)
        serviceaccount_test.go:63: GetServiceAccountName() = nameoidc-group-kind, want oidc-group-kind-name
    --- FAIL: TestGetOIDCServiceAccountNameForResource/should_return_SA_name_in_lower_case (0.00s)
        serviceaccount_test.go:63: GetServiceAccountName() = my-brokeroidc-eventing.knative.dev-broker, want oidc-eventing.knative.dev-broker-my-broker

Could you fix them?

[creydr]

Wow this was fast @MeenuyD 🚀
FYI: you can run the unit tests locally: go test ./pkg/... and in general the DEVELOPMENT.md provides some helpful resources to get started (if something is unclear we're happy to review PRs on improving these docs too).

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MeenuyD
Once this PR has been reviewed and has the lgtm label, please ask for approval from cali0707. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Cali0707]

@MeenuyD I think you need to change the want fields in the array of tests above. If you look at the test failures here, you'll see that they are failing because you changed the format of the string being returned by the function, and they are expecting the old format. So, just update the expected values and they should pass!

[knative-prow]

@MeenuyD: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
unit-tests_eventing_main	7ad1518	link	true	/test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[creydr]

@MeenuyD any updates on this? Can we help you with anything specific on this?

[MeenuyD]

Hello @creydr why the test cases are failing

[creydr]

Hello @creydr why the test cases are failing

In the unit test, the want defines the expected output (line 48 or 57). Since the output changed through this PR, the expected output in the tests need to be adjusted.

eventing/pkg/auth/serviceaccount_test.go

Lines 30 to 59 in 7ad1518

	func TestGetOIDCServiceAccountNameForResource(t *testing.T) {
	tests := []struct {
	name string
	gvk schema.GroupVersionKind
	objectMeta metav1.ObjectMeta
	want string
	}{
	{
	name: "should return SA name in correct format",
	gvk: schema.GroupVersionKind{
	Group: "group",
	Version: "version",
	Kind: "kind",
	},
	objectMeta: metav1.ObjectMeta{
	Name: "name",
	Namespace: "namespace",
	},
	want: "oidc-group-kind-name",
	},
	{
	name: "should return SA name in lower case",
	gvk: eventingv1.SchemeGroupVersion.WithKind("Broker"),
	objectMeta: metav1.ObjectMeta{
	Name: "my-Broker",
	Namespace: "my-Namespace",
	},
	want: "oidc-eventing.knative.dev-broker-my-broker",
	},
	}

To get more details, click on the "details" column of the failing test comment (#7471 (comment))

And your PR needs a rebase

[creydr]

@MeenuyD do you need any more information for this?

[creydr]

Closing this, as done in #7521