Upgrade tests account for last event being interrupted #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}
knative-prow
bot
added
area/test-and-release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7447 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 253 253
Lines 13916 13916
=======================================
Hits 10680 10680
Misses 2702 2702
Partials 534 534 ☔ View full report in Codecov by Sentry. |
|
/test upgrade-tests The test is failing from time to time but the failure doesn't look related to my changes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
mgencur
added a commit
to mgencur/eventing
that referenced
this pull request
Nov 20, 2023
* Fix reporting index of the failed step
The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}
* Upgrade tests account for last event being interrupted
mgencur
added a commit
to mgencur/eventing
that referenced
this pull request
Nov 20, 2023
* Fix reporting index of the failed step
The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}
* Upgrade tests account for last event being interrupted
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Dec 7, 2023
…#429) * Fix reporting index of the failed step The warning had a wrong index: {"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending step event #16691 to \"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""} {"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could not send step event 16690, retrying (1): Post \"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp 172.30.99.91:80: connect: connection refused"} * Upgrade tests account for last event being interrupted
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-eventing
that referenced
this pull request
Dec 7, 2023
* Fix reporting index of the failed step
The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending
step event #16691 to
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""}
{"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could
not send step event 16690, retrying (1): Post
\"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp
172.30.99.91:80: connect: connection refused"}
* Upgrade tests account for last event being interrupted
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Jan 2, 2024
…#458) * Fix reporting index of the failed step The warning had a wrong index: {"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending step event #16691 to \"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\""} {"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could not send step event 16690, retrying (1): Post \"http://sut-kn-channel.eventing-e2e0.svc.cluster.local\": dial tcp 172.30.99.91:80: connect: connection refused"} * Upgrade tests account for last event being interrupted Co-authored-by: Martin Gencur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7446
Proposed Changes
Pre-review Checklist
Release Note
Docs