Reduce mt-broker-controller memory usage with namespaced endpoint informer #7025
pierDipiknative-style.yaml
on: pull_request
style
/
changes
2s
style
/
...
/
Auto-format and Check
17s
style
/
...
/
Lint
2m 9s
style
/
...
/
Do Not Submit
5s
style
/
...
/
shell
0s
style
/
...
/
yaml
0s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
12 errors and 6 warnings
|
style / Golang / Auto-format and Check:
pkg/reconciler/broker/controller.go#L1
Please run goimports.
diff --git a/pkg/reconciler/broker/controller.go b/pkg/reconciler/broker/controller.go
index f6e104b..b369c31 100644
--- a/pkg/reconciler/broker/controller.go
+++ b/pkg/reconciler/broker/controller.go
@@ -18,9 +18,6 @@ package broker
import (
"context"
- "os"
-
- "knative.dev/pkg/injection"
"knative.dev/eventing/pkg/auth"
|
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
|
style / Golang / Lint:
cmd/mtchannel_broker/main.go#L31
could not import knative.dev/eventing/pkg/reconciler/broker (-: # knative.dev/eventing/pkg/reconciler/broker
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L21
"os" imported and not used
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L23
"knative.dev/pkg/injection" imported and not used
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L112
endpointsInformer.Lister undefined (type "k8s.io/client-go/tools/cache".SharedIndexInformer has no field or method Lister)
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L144
endpointsInformer.Informer undefined (type "k8s.io/client-go/tools/cache".SharedIndexInformer has no field or method Informer)
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L151
endpointsInformer.Informer undefined (type "k8s.io/client-go/tools/cache".SharedIndexInformer has no field or method Informer)) (typecheck)
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L21
"os" imported and not used
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L23
"knative.dev/pkg/injection" imported and not used
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L112
endpointsInformer.Lister undefined (type "k8s.io/client-go/tools/cache".SharedIndexInformer has no field or method Lister)
|
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L144
endpointsInformer.Informer undefined (type "k8s.io/client-go/tools/cache".SharedIndexInformer has no field or method Informer)
|
|
style / changes
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Do Not Submit
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|