Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend owners to WG leads #6172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Dec 5, 2024

Proposed Changes

  • Extend owners to WG leads

I propose to extend the current approvers to at least WGs leads. Considering the fact our docs are shared effort between all WGs and components. I'd even go with wg-writers, but that's a bit more folks.

/cc @knative/steering-committee

@knative-prow knative-prow bot requested a review from a team December 5, 2024 09:14
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Dec 5, 2024
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6da9f8d
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67516f47f7ff440008922448
😎 Deploy Preview https://deploy-preview-6172--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
Copy link

knative-prow bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

knative-prow bot commented Dec 5, 2024

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@dsimansk
Copy link
Contributor Author

dsimansk commented Dec 5, 2024

/hold for Steering to approve

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Dec 5, 2024
@dsimansk dsimansk changed the title Extend owners to WG writers Extend owners to WG leads Dec 5, 2024
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants