Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard-coded version #5902

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

Kai-Z-JP
Copy link
Contributor

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

Copy link

linux-foundation-easycla bot commented Mar 11, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from lionelvillard and nainaz March 11, 2024 06:12
Copy link

knative-prow bot commented Mar 11, 2024

Welcome @Kai-Z-JP! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2024
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8844df1
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65eea0d0a79f940008490277
😎 Deploy Preview https://deploy-preview-5902--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
Copy link

knative-prow bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kai-Z-JP, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@ReToCode
Copy link
Member

Thanks!

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

Thanks!

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit d187c5a into knative:main Mar 11, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5903

In response to this:

Thanks!

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
* fix hard-coded version of serving-core.yaml's url to env artifact

* change --8<-- to {% include %} for calling define_env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants