Sample Bookstore App: DB setup for Book Review Comments #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @Zazzscoot! It looks like this is your first PR to knative/docs 🎉 |
knative-prow
bot
added
the
size/M
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cc @Leo6Leo |
|
/lgtm |
Cali0707
suggested changes
Mar 8, 2024
Co-authored-by: Calum Murray <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
Cali0707
suggested changes
Mar 8, 2024
There was a problem hiding this comment.
Two more small changes then this is good on my end @Zazzscoot !
Co-authored-by: Calum Murray <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
Cali0707
approved these changes
Mar 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, Zazzscoot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
prushh
pushed a commit
to prushh/docs
that referenced
this pull request
Apr 30, 2024
* first commit, made table and wrote docs * removed book id * reduced amt of sample data * Update code-samples/eventing/bookstore-sample-app/db/sample.sql Co-authored-by: Calum Murray <[email protected]> * Update code-samples/eventing/bookstore-sample-app/db/sample.sql Co-authored-by: Calum Murray <[email protected]> * Update code-samples/eventing/bookstore-sample-app/db/sample.sql Co-authored-by: Calum Murray <[email protected]> * Update code-samples/eventing/bookstore-sample-app/db/sample.sql Co-authored-by: Calum Murray <[email protected]> --------- Co-authored-by: Calum Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5881
Proposed Changes