Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ceph Source to Event Sources #5895

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

zalsader
Copy link
Contributor

@zalsader zalsader commented Mar 6, 2024

Adds Ceph Source to the list of available Knative Eventing Sources

@knative-prow knative-prow bot requested review from pierDipi and ReToCode March 6, 2024 21:23
Copy link

knative-prow bot commented Mar 6, 2024

Welcome @zalsader! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9196e81
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65e8e06c07424300086366f0
😎 Deploy Preview https://deploy-preview-5895--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Zuhair AlSader <[email protected]>
@zalsader zalsader force-pushed the add-ceph-event-source branch from ac66a8e to 9196e81 Compare March 6, 2024 21:30
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @pierDipi

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@Cali0707
Copy link
Member

Cali0707 commented Mar 8, 2024

Thanks for this PR @zalsader

@zalsader zalsader requested a review from Cali0707 April 11, 2024 15:00
@pierDipi
Copy link
Member

/approve

Copy link

knative-prow bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, zalsader

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@knative-prow knative-prow bot merged commit 6dfdbfb into knative:main Apr 11, 2024
19 checks passed
@zalsader zalsader deleted the add-ceph-event-source branch April 11, 2024 15:10
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants