Case studies index page and link from homepage #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
aliok
force-pushed
the
2024-02-15-case-studies-index-page
branch
from
b8c28aa to
f1c3913
Compare
aliok
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
Leo6Leo
reviewed
Mar 1, 2024
docs/about/case-studies/README.md
Outdated
Comment on lines
10
to
26
| <td><a href="./deepc/"><img src="../../images/case-studies/deepc.png" alt="" draggable="false" style="max-width:300px;" /></a></td> | ||
| <td>AI Startup deepc Connects Researchers to Radiologists with Knative Eventing</td> | ||
| </tr> | ||
| <tr> | ||
| <td><a href="./outfit7/"><img src="../../images/case-studies/outfit7.png" alt="" draggable="false" style="max-width:300px;" /></a></td> | ||
| <td>Game maker Outfit7 automates high performance ad bidding with Knative Serving</td></tr> | ||
| <tr> | ||
| <td><a href="./pnc/"><img src="../../images/case-studies/pnc_bank.png" alt="" draggable="false" style="max-width:300px;" /></a></td> | ||
| <td>PNC Bank automated software supply chain compliance</td> | ||
| </tr> | ||
| <tr> | ||
| <td><a href="./puppet/"><img src="../../images/case-studies/puppet.png" alt="" draggable="false" style="max-width:300px;" /></a></td> | ||
| <td>Relay by Puppet Brings Workflows to Everything using Knative</td> | ||
| </tr> | ||
| <tr> | ||
| <td><a href="./sva/"><img src="../../images/case-studies/sva.png" alt="" draggable="false" style="max-width:300px;" /></a></td> | ||
| <td>SVA uses Knative to kickstart cloud native adoption and patterns</td> |
There was a problem hiding this comment.
I think it would provide a better user experience if we make the whole table row clickable. Right now users have to click on the image in order to be redirected. Also the text can be centered to provide a better visual experience!
I made these changes in this PR. aliok#1
This is how it looks. @aliok Lmk if you think this is a reasonable change!
There was a problem hiding this comment.
change the styling, and make the whole table row clickable
|
/lgtm |
prushh
pushed a commit
to prushh/docs
that referenced
this pull request
Apr 30, 2024
* Link to case studies Signed-off-by: Ali Ok <[email protected]> * Add a case studies page to link from homepage Signed-off-by: Ali Ok <[email protected]> * change the styling, and make the whole table row clickable --------- Signed-off-by: Ali Ok <[email protected]> Co-authored-by: Leo Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes #issue-number" or "Add description of the problem this PR solves"
Problem
Proposed Changes