Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention auto-create on event registry doc #5844

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Mention auto-create on event registry doc #5844

merged 1 commit into from
Jan 30, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jan 30, 2024

Proposed Changes

  • adding hint about auto create on event registry doc

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7edff3f
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65b8f06cafba9b00099dc18d
😎 Deploy Preview https://deploy-preview-5844--knative.netlify.app/docs/eventing/event-registry
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from pierDipi and ReToCode January 30, 2024 12:49
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2024
dsimansk
dsimansk approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@knative-prow knative-prow bot merged commit 2b59dce into knative:main Jan 30, 2024
19 checks passed
@matzew
Copy link
Member Author

matzew commented Jan 30, 2024

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #5845

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jan 30, 2024
Merged
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@matzew @prushh
Mention auto-create on event registry doc (knative#5844)
a4029dc 
Signed-off-by: Matthias Wessendorf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk approved these changes

@pierDipi pierDipi Awaiting requested review from pierDipi

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @knative-prow-robot @dsimansk