new trigger filters now in beta #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pingjiang <[email protected]>
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
knative-prow
bot
added
the
size/XS
Cali0707
suggested changes
Oct 12, 2023
There was a problem hiding this comment.
Hey @xiangpingjiang thanks for picking this up!
Two things:
- Can you also update the table on https://deploy-preview-5713--knative.netlify.app/docs/eventing/experimental-features/ to mark this feature as Beta, enabled by default
- In https://deploy-preview-5713--knative.netlify.app/docs/eventing/triggers/#trigger-filtering can you add a link to the new trigger filters page and mention that we have this beta feature if they need more powerful filtering options?
Signed-off-by: pingjiang <[email protected]>
Cali0707
suggested changes
Oct 16, 2023
docs/eventing/triggers/README.md
Outdated
| @@ -100,6 +100,9 @@ This example filters events from the `default` broker that are of type | |||
| ``` | |||
| Where `<filename>` is the name of the file you created in the previous step. | |||
|
|
|||
| ### New trigger filters | |||
|
|
|||
| if you need more powerful filtering options, you can use the [New trigger filters](https://knative.dev/docs/eventing/experimental-features/new-trigger-filters/). | |||
There was a problem hiding this comment.
Suggested change
| if you need more powerful filtering options, you can use the [New trigger filters](https://knative.dev/docs/eventing/experimental-features/new-trigger-filters/). | |
| If you need more powerful filtering options, you can use the [new trigger filters](../experimental-features/new-trigger-filters). |
The links should be relative filepaths, rather than a hardcoded URL
Signed-off-by: pingjiang <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, xiangpingjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes #5710"
Proposed Changes