Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio supported versions change #5134

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

AngeloDanducci
Copy link
Contributor

Link to the net-istio releases github page as the source of truth for supported versions per release instead of having a hard coded value.

Description of problem the PR solves:
Received messages on slack asking which versions of Istio we support and the docs page is out of date.
Linking to the net-istio releases page seems a better strategy in combination with this issue as opposed to updating the documentation every time.

Worst case scenario the release notes can be updated manually instead of new documentation PRs.

Proposed Changes

  • Link to the net-istio release page to show supported Istio version instead of hard coding.

Link to the net-istio releases github page as the source of truth for supported versions per release instead of having a hard coded value.
@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 964de7f
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/62e1a8a1f4c9790008d58450
😎 Deploy Preview https://deploy-preview-5134--knative.netlify.app/docs/install/installing-istio
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2022
@dprotaso
Copy link
Member

LGTM

deferring to docs folks for the copy

@dprotaso
Copy link
Member

also note: we'll want to cherry pick this change back to prior release branches - since I believe we adopted newer versions of istio in prior releases

@abrennan89
Copy link
Contributor

/cherrypick release-1.6

@knative-prow-robot
Copy link
Contributor

@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

/cherrypick release-1.5

@knative-prow-robot
Copy link
Contributor

@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

/cherrypick release-1.4

@knative-prow-robot
Copy link
Contributor

@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

/cherrypick release-1.3

@knative-prow-robot
Copy link
Contributor

@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, AngeloDanducci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@knative-prow knative-prow bot merged commit 6d5d08b into knative:main Jul 27, 2022
@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #5143

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #5144

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #5145

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #5146

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants