-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PingSourve to v1 API version #1991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsimansk: 0 warnings.
In response to this:
Description
Changes
- Refactor PingSourve to v1 API version
Reference
Fixes #1975
Release Note
Refactor PingSourve to v1 API version
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Looks straightforward to me
/approve
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
- Coverage 73.71% 73.64% -0.07%
==========================================
Files 234 233 -1
Lines 16477 16461 -16
==========================================
- Hits 12146 12123 -23
- Misses 3504 3509 +5
- Partials 827 829 +2 ☔ View full report in Codecov by Sentry. |
/retest |
Description
Changes
Reference
Fixes #1975
Release Note
/cc @rhuss @cardil