Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PingSourve to v1 API version #1991

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

dsimansk
Copy link
Contributor

Description

Changes

  • Refactor PingSourve to v1 API version

Reference

Fixes #1975

Release Note

Refactor PingSourve to v1 API version

/cc @rhuss @cardil

@knative-prow knative-prow bot requested review from cardil and rhuss January 20, 2025 17:08
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 0 warnings.

In response to this:

Description

Changes

  • Refactor PingSourve to v1 API version

Reference

Fixes #1975

Release Note

Refactor PingSourve to v1 API version

/cc @rhuss @cardil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2025
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks straightforward to me

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@rhuss
Copy link
Contributor

rhuss commented Jan 20, 2025

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
Copy link

knative-prow bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.64%. Comparing base (8d10f67) to head (79acdaa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sources/v1/ping_client_mock.go 62.50% 3 Missing ⚠️
pkg/commands/source/ping/ping.go 33.33% 2 Missing ⚠️
pkg/commands/source/ping/flags.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
- Coverage   73.71%   73.64%   -0.07%     
==========================================
  Files         234      233       -1     
  Lines       16477    16461      -16     
==========================================
- Hits        12146    12123      -23     
- Misses       3504     3509       +5     
- Partials      827      829       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhuss
Copy link
Contributor

rhuss commented Jan 20, 2025

/retest

@knative-prow knative-prow bot merged commit 9baddba into knative:main Jan 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PingSource to v1
2 participants