-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package location for build flags #1978
Conversation
/cherry-pick release-1.16 |
@dsimansk: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @dsimansk for fixing this! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
=======================================
Coverage 73.70% 73.70%
=======================================
Files 234 234
Lines 16482 16482
=======================================
Hits 12148 12148
Misses 3506 3506
Partials 828 828 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@dsimansk: new pull request created: #1979 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Changes
Reference
Fixes #
Release Note
/cc @rhuss @cardil
@cardil that's an overlooked issue from the client-pkg migration.
Fixes #1977