Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package location for build flags #1978

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dsimansk
Copy link
Contributor

Description

Changes

  • Fix package location for build flags

Reference

Fixes #

Release Note

 Fix `version` command to dispaly proper version string

/cc @rhuss @cardil

@cardil that's an overlooked issue from the client-pkg migration.

Fixes #1977

@knative-prow knative-prow bot requested review from cardil and rhuss November 19, 2024 16:19
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@dsimansk
Copy link
Contributor Author

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2024
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
Copy link

knative-prow bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Contributor

cardil commented Nov 19, 2024

Thanks @dsimansk for fixing this!

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.70%. Comparing base (f94c31b) to head (b035b75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1978   +/-   ##
=======================================
  Coverage   73.70%   73.70%           
=======================================
  Files         234      234           
  Lines       16482    16482           
=======================================
  Hits        12148    12148           
  Misses       3506     3506           
  Partials      828      828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@knative-prow knative-prow bot merged commit bfc00b8 into knative:main Nov 19, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@dsimansk: new pull request created: #1979

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty version info when use "kn version"
3 participants