Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Update x/net lib to v0.17.0 version #1876

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Oct 12, 2023

Description

Changes

  • Update x/net lib to v0.17.0 version to address CVE

Even though the server-side code isn't used in context of kn.

Any /lgtm will work, thanks!
/cc @rhuss @matzew @ReToCode

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b7508e6) 79.67% compared to head (ddd6c92) 79.67%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.11    #1876   +/-   ##
=============================================
  Coverage         79.67%   79.67%           
=============================================
  Files               179      179           
  Lines             13938    13938           
=============================================
  Hits              11105    11105           
  Misses             2067     2067           
  Partials            766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk dsimansk changed the title Update x/net lib to v0.17.0 version [release-1.11] Update x/net lib to v0.17.0 version Oct 12, 2023
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit eca7388 into knative:release-1.11 Oct 12, 2023
17 checks passed
dsimansk added a commit to openshift-knative/client that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants