Add missing probes (knative-extensions#1095)

* add probes * make thresholds different * cleanup * add delay for webhook
knative-prow-robot · Apr 25, 2023 · 718312e · 718312e
1 parent 4f982a2
commit 718312e
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 0 deletions.
diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go
@@ -84,6 +84,7 @@ func main() {
 		Port:        webhook.PortFromEnv(8443),
 	})
 
+	ctx = sharedmain.WithHealthProbesDisabled(ctx)
 	sharedmain.WebhookMainWithContext(
 		ctx, "net-istio-webhook",
 		certificates.NewController,

diff --git a/config/500-controller.yaml b/config/500-controller.yaml
@@ -81,11 +81,28 @@ spec:
           seccompProfile:
             type: RuntimeDefault
 
+        readinessProbe:
+          httpGet:
+            path: /readiness
+            port: probes
+            scheme: HTTP
+          periodSeconds: 5
+          failureThreshold: 3
+        livenessProbe:
+          httpGet:
+            path: /health
+            port: probes
+            scheme: HTTP
+          periodSeconds: 5
+          failureThreshold: 6
+
         ports:
         - name: metrics
           containerPort: 9090
         - name: profiling
           containerPort: 8008
+        - name: probes
+          containerPort: 8080
 
 # Unlike other controllers, this doesn't need a Service defined for metrics and
 # profiling because it opts out of the mesh (see annotation above).
diff --git a/config/500-webhook-deployment.yaml b/config/500-webhook-deployment.yaml
@@ -82,6 +82,26 @@ spec:
           seccompProfile:
             type: RuntimeDefault
 
+        readinessProbe:
+          periodSeconds: 1
+          httpGet:
+            scheme: HTTPS
+            port: 8443
+            httpHeaders:
+              - name: k-kubelet-probe
+                value: "webhook"
+          failureThreshold: 3
+        livenessProbe:
+          periodSeconds: 1
+          httpGet:
+            scheme: HTTPS
+            port: 8443
+            httpHeaders:
+              - name: k-kubelet-probe
+                value: "webhook"
+          failureThreshold: 6
+          initialDelaySeconds: 20
+
         ports:
         - name: metrics
           containerPort: 9090