Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP update deps #336

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

davidhadas
Copy link
Contributor

@davidhadas davidhadas commented Jan 30, 2025

Upgrade K8s packages, hopefully will fix security-guard failures on automated updates - https://github.com/knative-extensions/knobots/actions/runs/13052957934 as suggested by @dprotaso

This PR includes:
go get -u k8s.io/gengo
go get -u k8s.io/gengo/v2
go get -u k8s.io/code-generator
go get -u k8s.io/api
go get -u k8s.io/client-go

and then:
./hack/update-codegen.sh

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.94%. Comparing base (84c5d78) to head (d842384).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   74.01%   73.94%   -0.08%     
==========================================
  Files          46       46              
  Lines        4257     4257              
==========================================
- Hits         3151     3148       -3     
- Misses        973      975       +2     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@evankanderson
Copy link
Contributor

I don't see any dependencies. Should we turn on Dependabot for these?

@davidhadas davidhadas changed the title update deps WIP update deps Jan 31, 2025
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
Copy link

knative-prow bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@davidhadas
Copy link
Contributor Author

I don't see any dependencies. Should we turn on Dependabot for these?

Yep, it was WIP, now complete.
See revised description for details
Needs /lgtm.

@davidhadas davidhadas removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@davidhadas davidhadas self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants