Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Go 1.17 #932

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Move to Go 1.17 #932

merged 2 commits into from
Jun 15, 2022

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 23, 2022

Changes

  • Other components like net-kourier have already moved to 1.17.
  • Two commits for easier review.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 23, 2022
@knative-prow
Copy link

knative-prow bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #932 (9ab0b80) into main (9ab0b80) will not change coverage.
The diff coverage is n/a.

❗ Current head 9ab0b80 differs from pull request most recent head 584a1c5. Consider uploading reports for the commit 584a1c5 to get more accurate results

@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          18       18           
  Lines        1603     1603           
=======================================
  Hits         1300     1300           
  Misses        221      221           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab0b80...584a1c5. Read the comment docs.

@nak3
Copy link
Contributor

nak3 commented May 23, 2022

/lgtm
/hold

/hold for CI.
Just FYI, I am planning to propose this change knative/hack#179 to make the project uses the same Go version consistently.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2022
@skonto
Copy link
Contributor Author

skonto commented May 23, 2022

/retest

1 similar comment
@dprotaso
Copy link
Contributor

/retest

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@skonto
Copy link
Contributor Author

skonto commented May 30, 2022

Rebased. @nak3 gentle ping.

@skonto
Copy link
Contributor Author

skonto commented May 30, 2022

/retest

3 similar comments
@skonto
Copy link
Contributor Author

skonto commented Jun 1, 2022

/retest

@dprotaso
Copy link
Contributor

dprotaso commented Jun 7, 2022

/retest

@skonto
Copy link
Contributor Author

skonto commented Jun 9, 2022

/retest

@skonto
Copy link
Contributor Author

skonto commented Jun 9, 2022

@nak3 gentle ping this is ready.

@skonto skonto requested a review from nak3 June 9, 2022 09:04
@nak3
Copy link
Contributor

nak3 commented Jun 9, 2022

/lgtm
/hold cancel

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 9, 2022
@skonto
Copy link
Contributor Author

skonto commented Jun 9, 2022

/retest

@dprotaso
Copy link
Contributor

dprotaso commented Jun 9, 2022

Related issue: #938

@AngeloDanducci this PR seems to reproduce this reliably

@AngeloDanducci
Copy link
Contributor

/retest

@AngeloDanducci
Copy link
Contributor

Opened an issue related to the error we're seeing here: #938

Seems like it may be related to something opened previously in upstream Istio.

@knative-prow knative-prow bot merged commit 7b66ef0 into knative-extensions:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nak3 nak3 Awaiting requested review from nak3

Assignees

@nak3 nak3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skonto @nak3 @dprotaso @AngeloDanducci @knative-prow-robot