Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] debugging flakes #1080

Closed
wants to merge 6 commits into from
Closed

[wip] debugging flakes #1080

wants to merge 6 commits into from

Conversation

dprotaso
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

Merging #1080 (7072c09) into main (e2884b4) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 7072c09 differs from pull request most recent head 7462b67. Consider uploading reports for the commit 7462b67 to get more accurate results

@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
- Coverage   82.10%   81.92%   -0.19%     
==========================================
  Files          18       18              
  Lines        1643     1643              
==========================================
- Hits         1349     1346       -3     
- Misses        212      214       +2     
- Partials       82       83       +1

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2023
@dprotaso
Copy link
Contributor Author

wtf

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2023
@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2023
@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2023
@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

6 similar comments
@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@dprotaso
Copy link
Contributor Author

/test integration-tests_net-istio_main
/test latest_net-istio_main
/test latest-mesh_net-istio_main

@dprotaso
Copy link
Contributor Author

Closing this out #938 (comment)

@dprotaso dprotaso closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dprotaso