Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker support! #227

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

Docker support! #227

wants to merge 24 commits into from

Conversation

neve360
Copy link

@neve360 neve360 commented Nov 25, 2024

This version add full compatibility with docker and you can see it running with vnc

klept0 and others added 24 commits September 9, 2024 08:32
@klept0
Update stale.yml
50e76c6
@dependabot
Update apprise requirement from ~=1.8.1 to ~=1.9.0
ee7d86e 
Updates the requirements on [apprise](https://github.com/caronc/apprise) to permit the latest version.
- [Release notes](https://github.com/caronc/apprise/releases)
- [Commits](caronc/apprise@v1.8.1...1.9.0)

---
updated-dependencies:
- dependency-name: apprise
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@klept0
Update apprise requirement from ~=1.8.1 to ~=1.9.0 (klept0#207)
24a63e4 
Updates the requirements on [apprise](https://github.com/caronc/apprise)
to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/caronc/apprise/releases">apprise's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.9.0</h2>
<h2>What's Changed</h2>
<p>The largest change introduced in this build is the new Persistent
Storage setup which will greatly reduce and optimize a lot of existing
and new supported plugins.</p>
<h3>:mega: New Notification Services:</h3>
<ul>
<li>WxPusher Support Added in <a
href="https://redirect.github.com/caronc/apprise/pull/1135">caronc/apprise#1135</a></li>
</ul>
<h3>:bulb: Features</h3>
<ul>
<li>:rocket: :star: Persistent Storage in <a
href="https://redirect.github.com/caronc/apprise/pull/1131">caronc/apprise#1131</a>
(more then 6,500+ lines of code added to the code base) 🔥
<ul>
<li>This feature is very big and better <a
href="https://github.com/caronc/apprise/wiki/persistent_storage">documented
here</a>. Some general details can also be found <a
href="https://github.com/caronc/apprise?tab=readme-ov-file#persistent-storage">here</a>
on the main README.md file.</li>
<li>Long overdue, plugins can now safely cache some of the query results
returned from upstream endpoints to disk. This saves the need to make
future extra web requests later (overall causing a performance boost to
Apprise).</li>
<li>It's a cache engine done right; content is contained, and those
using the CLI can clean/reset it. You can also easily turn it off.</li>
<li>Not all plugins that can fully leverage this for it's added boost do
so... *Yet*, but just give me some time and I'll get there.</li>
</ul>
</li>
<li>mqtt:// support for publishing retain flag in <a
href="https://redirect.github.com/caronc/apprise/pull/1185">caronc/apprise#1185</a></li>
<li>SendGrid Attachment Support Added in <a
href="https://redirect.github.com/caronc/apprise/pull/1190">caronc/apprise#1190</a></li>
<li>Refactored base64 attachment handling in <a
href="https://redirect.github.com/caronc/apprise/pull/1191">caronc/apprise#1191</a></li>
</ul>
<h3>:heart: Life-Cycle Support</h3>
<ul>
<li>Documentation and CLI Tidying in <a
href="https://redirect.github.com/caronc/apprise/pull/1187">caronc/apprise#1187</a></li>
<li>Cleaner usage of Apprise CLI
(0d19db862d31b34151ff682244a4565d532860dd)</li>
<li>RPM Testing/Building Docker Containers smaller in size
(1a2eecc448b25bcd6f1e5353a6c9e05ceb859e59 and
1dc22e1dd633c4718665d8c0a3501fb488f8c2f1) refs <a
href="https://redirect.github.com/caronc/apprise/issues/948">#948</a></li>
</ul>
<h3>:lady_beetle:  Bugfixes</h3>
<ul>
<li>Fix typo in readme by <a
href="https://github.com/khaffner"><code>@​khaffner</code></a> in <a
href="https://redirect.github.com/caronc/apprise/pull/1176">caronc/apprise#1176</a></li>
<li>Fix Telegram Thread/Topic handling in <a
href="https://redirect.github.com/caronc/apprise/pull/1177">caronc/apprise#1177</a></li>
<li>Fixed mattermost channel handling n <a
href="https://redirect.github.com/caronc/apprise/pull/1180">caronc/apprise#1180</a></li>
<li>Escape unsupported Telegram MarkdownV2 characters in <a
href="https://redirect.github.com/caronc/apprise/pull/1181">caronc/apprise#1181</a>
<ul>
<li>Telegram MarkdownV2 has turned out to be a VERY different style of
markdown. For consistency, the default telegram mode is version 1.
Simply add <code>?format=markdown&amp;mdv=v2</code> to your URL to
change this.</li>
</ul>
</li>
</ul>
<h2>Installation</h2>
<p>Apprise is available <a href="https://pypi.org/project/apprise/">on
PyPI</a> through <em>pip</em>:</p>
<pre lang="bash"><code># Install Apprise v1.9.0 from PyPI
pip install apprise==1.9.0
</code></pre>
<h2>New Contributors 🎉</h2>
<ul>
<li><a href="https://github.com/khaffner"><code>@​khaffner</code></a>
made their first contribution in <a
href="https://redirect.github.com/caronc/apprise/pull/1176">caronc/apprise#1176</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/caronc/apprise/compare/v1.8.1...v1.9.0">https://github.com/caronc/apprise/compare/v1.8.1...v1.9.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/caronc/apprise/commit/09cd2b6de6748313fef93bd5b800153a95ab6866"><code>09cd2b6</code></a>
bumped version to v1.9.0</li>
<li><a
href="https://github.com/caronc/apprise/commit/0d19db862d31b34151ff682244a4565d532860dd"><code>0d19db8</code></a>
cli errors leverage click output and suggest --help</li>
<li><a
href="https://github.com/caronc/apprise/commit/1a2eecc448b25bcd6f1e5353a6c9e05ceb859e59"><code>1a2eecc</code></a>
Missed Dockerfile tidying ref <a
href="https://redirect.github.com/caronc/apprise/issues/948">#948</a></li>
<li><a
href="https://github.com/caronc/apprise/commit/fa6d4e67434948c26ad7b481e1a7410a28a804a1"><code>fa6d4e6</code></a>
Persistent storage code tidying (<a
href="https://redirect.github.com/caronc/apprise/issues/1199">#1199</a>)</li>
<li><a
href="https://github.com/caronc/apprise/commit/1dc22e1dd633c4718665d8c0a3501fb488f8c2f1"><code>1dc22e1</code></a>
smaller rpm build docker containers; ref <a
href="https://redirect.github.com/caronc/apprise/issues/948">#948</a></li>
<li><a
href="https://github.com/caronc/apprise/commit/e3e34c42112c071ab66dd9cc0e76c2213ce74a80"><code>e3e34c4</code></a>
WxPusher Support Added (<a
href="https://redirect.github.com/caronc/apprise/issues/1135">#1135</a>)</li>
<li><a
href="https://github.com/caronc/apprise/commit/98fb4865fc108c812f3ae72eee67824666886e8d"><code>98fb486</code></a>
Refactored base64 attachment handling (<a
href="https://redirect.github.com/caronc/apprise/issues/1191">#1191</a>)</li>
<li><a
href="https://github.com/caronc/apprise/commit/ca50cb7820a889a83843c9e8d79ac6e68535790b"><code>ca50cb7</code></a>
SendGrid Attachment Support Added (<a
href="https://redirect.github.com/caronc/apprise/issues/1190">#1190</a>)</li>
<li><a
href="https://github.com/caronc/apprise/commit/3cb270cee8d1e36e4fb21e15de4b1588ee3ee50d"><code>3cb270c</code></a>
Documentation and CLI Tidying (<a
href="https://redirect.github.com/caronc/apprise/issues/1187">#1187</a>)</li>
<li><a
href="https://github.com/caronc/apprise/commit/9addff8cfbed80785f604b961fa6ca0a4563e30e"><code>9addff8</code></a>
mqtt:// support for publishing retain flag (<a
href="https://redirect.github.com/caronc/apprise/issues/1185">#1185</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/caronc/apprise/compare/v1.8.1...1.9.0">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
@neve360
fixed args for browser and fixed timeoutExeption
5d5a5e6
@neve360
fixed entering timeoutexception loop
ba2f0e4
@neve360
Delete .github directory
d9389c2
@neve360
Delete .idea directory
e428a4a
@neve360
Delete .trunk directory
abb4762
@neve360
Delete .vscode directory
22571da
@neve360
Delete src directory
9b5d097
@neve360
Delete test directory
0c76f40
@neve360
Delete .flake8
a1f0717
@neve360
Delete .gitignore
1847152
@neve360
Delete .pylintrc
d34a4e1
@neve360
Delete .template-config-private.yaml
36b416d
@neve360
Delete CHANGELOG.md
af6cfd9
@neve360
Delete LICENSE
2b87a39
@neve360
Delete MS_reward.bat
92ad6c0
@neve360
Delete accounts.json.sample
93e99f9
@neve360
Delete config.yaml
94d9e70
@neve360
Delete generate_task_xml.py
ceced93
@neve360
Delete main.py
d8266a0
@neve360
Delete requirements.txt
2d9ada3
@neve360
Docker works and tells your ip when running
f0e27c8
@cal4 cal4 changed the base branch from master to develop November 25, 2024 20:14
@cal4
Copy link
Collaborator

cal4 commented Nov 25, 2024

Thanks for contributing! See if you can resolve the conflicts with the existing Docker code in develop.

Also, we'll need to restore all the deleted files.

@neve360
Copy link
Author

neve360 commented Nov 26, 2024 •
edited
Loading

hi cal, if you could make a branch with that because with docker it needs to create those file so the user (watch docker tutorial install) could run the command with the args. the existing code cannot be fixed. if you watch telegram you will see messages from me and other users that a reporting constant freezing of your version(it needs to be visible the selenium window and your version doesn't have a display), if u use multi account u need to make a lot of images with different things unlike mine. i also added in the logger to display the current ip so if u are using proxy u can see if those actually works.

@neve360
Copy link
Author

neve360 commented Dec 3, 2024

cal?

@cal4
Copy link
Collaborator

cal4 commented Dec 3, 2024 •
edited
Loading

Yeah running the bot via Docker is beta and I can't personally vouch for it since I don't run it that way (and don't plan to tbh). I don't doubt that it's not working correctly. At the same time, I don't see any reason to gate-keep the feature.

All that being said, in order for this to get merged all of the deleted files need to be restored. Conflicts need to be resolved as well. Since I don't personally use this feature, I don't plan on doing either so it's on you.

Appreciate you contributing, but at a minimum we need to restore those files before merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neve360 @cal4 @klept0