PagerDuty incident resolution support #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettheel
reviewed
Oct 15, 2016
| event_type = 'resolve' | ||
|
|
||
| # Extract unique alert identifiers | ||
| alert_name = message[message.find("<")+1:message.find(">")] |
There was a problem hiding this comment.
Can you use the context passed into the function for the alert name and metric name instead of pulling it out of the message?
| h.update(alert_metric) | ||
|
|
||
| # Use hash as incident key to support resolution | ||
| incident_key = h.hexdigest() |
There was a problem hiding this comment.
Is there any benefit to md5ing these? Why not just do "{alert_name:alert_metric}"?
| # Use hash as incident key to support resolution | ||
| incident_key = h.hexdigest() | ||
|
|
||
| if level == 'critical': |
There was a problem hiding this comment.
if level in ['critical', 'warning']:
| else: | ||
| event_type = 'trigger' | ||
| return |
There was a problem hiding this comment.
Is there a reason you're changing this?
| "event_type": event_type, | ||
| "description": message, | ||
| "details": message, | ||
| "incident_key": rule['raw'] if rule is not None else 'graphite connect error', |
There was a problem hiding this comment.
Looks like this logic has has been lost, can you re-add it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PagerDuty incidents are generated with messages like:
"Back to normal" messages look like:
From those, I figured that incident-unique information is the combination of alert name (
<Test Wildcard Alert>) and metrics name ((stats.gauges.server1.data)). To avoid storing data on the file system, I decided to generate a hash out of those two. Using this hash value incidents can be triggered and resolved in a stateless way.Following tests were performed:
"query": "stats.gauges.test")"query": "stats.gauges.*.data")