Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

202406 update viewed product #41

Closed
wants to merge 5 commits into from
Closed

202406 update viewed product #41

wants to merge 5 commits into from

Conversation

cykolln
Copy link
Contributor

@cykolln cykolln commented Jun 12, 2024

Description

  1. Removes option to brand Viewed Product and Add/Added to Cart events as SFCC in Klaviyo
  2. Adds a new field to Viewed Product events ProductID which is compatible with Klaviyo's internal recommendations engine
  3. updates the copy on the site configuration to specify that Viewed Product and Add/Added to Cart will never be branded.
image

Manual Testing Steps

  1. Verified that when the option to brand events is selected, we still do not brand Viewed Product and Add / Added to Cart by testing all events.
  2. Verified that when the option to brand events is not selected, no events are branded.
  3. Verified that ProductID is included in the Viewed Product Payload
  4. Ran unit tests, e2e tests to make sure all existing functionality is still intact.

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@cykolln cykolln requested a review from a team as a code owner June 12, 2024 21:31
@klaviyoit klaviyoit requested a review from jordanleslie June 12, 2024 21:31
smoucka
smoucka approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@smoucka smoucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the detailed test plan!

@cykolln cykolln closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanleslie jordanleslie jordanleslie approved these changes

@smoucka smoucka smoucka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cykolln @smoucka @jordanleslie