Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Finnish to its own "namespace" #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tonikaihola
Copy link
Contributor

No description provided.

Copy link
Owner

@kkokosa kkokosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be much better to use real namespaces, could you change that? So instead of a class inside class, just have two Strings classes:

namespace String.Abbreviations.EN
{
    public static class Strings
    {
    ...

and

namespace String.Abbreviations.FI
{
    public static class Strings
    {
    ...
}

BTW it is much cleaner to make PR from your local branch, now it contains the whole commit history because it is from master.

@tonikaihola
Copy link
Contributor Author

tonikaihola commented Sep 24, 2020

Yeah, I'll change to a proper namespace.

BTW it is much cleaner to make PR from your local branch, now it contains the whole commit history because it is from master.

My github-fu is too weak for that at the moment but I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants