Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust sizing of the member cards, paddings #83

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Adjust sizing of the member cards, paddings #83

merged 2 commits into from
Dec 23, 2024

Conversation

CheddarChoi
Copy link
Contributor

  • Smaller size for the people card
  • Adjust the spacing between information of member card
  • More space for the sidebar

@netlify Netlify
Copy link

netlify bot commented Dec 22, 2024 •
edited
Loading

✅ Deploy Preview for kixlab ready!

Name Link
🔨 Latest commit 3a5d14e
🔍 Latest deploy log https://app.netlify.com/sites/kixlab/deploys/6767cea6c1e7240008364900
😎 Deploy Preview https://deploy-preview-83--kixlab.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 71 (🔴 down 22 from production)
Accessibility: 98 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CheddarChoi
Copy link
Contributor Author

Also removed 'react-viewport-list' which was a cause of the publication search issue raised in slack channel

jhw123
jhw123 approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@jhw123 jhw123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhw123
Copy link
Member

jhw123 commented Dec 22, 2024

Nice PR description, which many people often forget to edit.

@CheddarChoi CheddarChoi merged commit 2137e94 into main Dec 23, 2024
5 checks passed
@CheddarChoi CheddarChoi deleted the design-updates branch December 23, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhw123 jhw123 jhw123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CheddarChoi @jhw123