Update PHP versions in run-tests.yml and skip test

on Windows and PHP versions greater than 8.2
kiwilan · Dec 6, 2023 · bee1fee · bee1fee
1 parent 9c70ddd
commit bee1fee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -9,7 +9,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest]
-        php: [8.1, 8.2]
+        php: [8.1, 8.2, 8.3]
         stability: [prefer-stable]
 
     name: P${{ matrix.php }} - ${{ matrix.stability }} - ${{ matrix.os }}

diff --git a/tests/PdfTest.php b/tests/PdfTest.php
@@ -31,7 +31,7 @@
     expect(file_exists($path))->toBeTrue();
     expect($path)->toBeReadableFile();
     expect(fileIsValidImg($path))->toBeTrue();
-})->skip(PHP_OS_FAMILY === 'Windows', 'Skip on Windows');
+})->skip(PHP_OS_FAMILY === 'Windows' || PHP_VERSION > '8.2', 'Skip on Windows');
 
 it('can parse empty pdf', function () {
     $ebook = Ebook::read(PDF_EMPTY);