Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.01 #55

Merged
merged 8 commits into from
Jan 18, 2025
Merged

v2.3.01 #55

merged 8 commits into from
Jan 18, 2025

Conversation

ewilan-riviere
Copy link
Contributor

@ewilan-riviere ewilan-riviere commented Jan 18, 2025

PR #54 by @onigoetz: Various bugfixes due to humans being humans

  • Missing escaping of CLI arguments
  • Errors swallowed hiding the original error
  • Sometimes a .cbz is a RAR file, sometimes a .cbr is a ZIP file

Thanks to @onigoetz for the PR!

Note: macOS test with RAR extension removed.

@ewilan-riviere ewilan-riviere self-assigned this Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (dc878c7) to head (8464597).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #55      +/-   ##
============================================
- Coverage     90.90%   89.63%   -1.27%     
- Complexity      314      327      +13     
============================================
  Files            14       14              
  Lines          1055     1090      +35     
============================================
+ Hits            959      977      +18     
- Misses           96      113      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewilan-riviere ewilan-riviere merged commit b45a04c into main Jan 18, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant