Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also attempt to find plugin using prelim url #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ItsOnlyBinary
Copy link
Contributor

current implementation requires a specific plugin name in config.json, this makes it a little more forgiving as it also attempts to use the url to find its self

@prawnsalad
Copy link
Member

I think this issue is more rooted in that plugin configuration can be a little awkward at the moment. We should think about having a different plugin structure in kiwiirc core so that each plugin has its own config object passed to it directly

@ItsOnlyBinary
Copy link
Contributor Author

Its the way the preloader finds its location so it can load the full plugin, it relies on plugin name in the config for its url

i was going to pass the plugin name to the plugin constructor function but it appears the preloader doesnt use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants