Add Playroom integration #4576
Open
Add Playroom integration #4576
+4,304
−1,107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Size Change: +1 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
9935cac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a9ffe201.orbit.pages.dev |
| Branch Preview URL: | https://devin-1736720770-playroom-se.orbit.pages.dev |
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
5 times, most recently
from
ad98184 to
fd6ec03
Compare
devin-ai-integration
bot
force-pushed
the
devin/1736720770-playroom-setup
branch
from
fd6ec03 to
9f11c38
Compare
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
10 times, most recently
from
c48324a to
07f47d4
Compare
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
from
b97c88c to
9c8f970
Compare
|
Storybook staging is available at https://kiwicom-orbit-devin-1736720770-playroom-setup.surge.sh |
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
4 times, most recently
from
51911da to
d9f8770
Compare
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
from
d9f8770 to
96b3710
Compare
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
from
96b3710 to
956ef68
Compare
sarkaaa
reviewed
Jan 21, 2025
| const FrameComponent = ({ children }) => { | ||
| return ( | ||
| <OrbitProvider theme={defaultTheme} useId={React.useId}> | ||
| <div id="playroom-frame" dir="ltr"> |
There was a problem hiding this comment.
It looks like playroom-frame is not used anywhere. Is it necessary to specify the id and dir attributes here?
There was a problem hiding this comment.
The dir yes. Some components rely on it. The id is just a good practice. Doesn't harm to keep. It helps with DOM debug.
Co-Authored-By: [email protected] <[email protected]>
The code now exposes the provider and a wrapper div, also allowing for more customization
It was not behaving as expected. To be fixed later
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
from
956ef68 to
453b519
Compare
|
Storybook staging is available at https://kiwicom-orbit-devin-1736720770-playroom-setup.surge.sh Playroom staging is available at https://kiwicom-orbit-devin-1736720770-playroom-setup.surge.sh/playroom |
DSil
force-pushed
the
devin/1736720770-playroom-setup
branch
from
453b519 to
9935cac
Compare
| @@ -9,7 +9,7 @@ import ReadArt from "../../images/streamline-light/read-art.svg"; | |||
| import IrisScanIcon from "../../images/streamline-light/iris-scan.svg"; | |||
| import ScriptIcon from "../../images/streamline-light/script.svg"; | |||
|
|
|||
| type Link = "Components" | "Guides" | "Tokens" | "Accessibility" | "Foundation" | "Playground"; | |||
There was a problem hiding this comment.
Will we remove the playground logic? If so, will it be part of a different task?
In case we want to create a ticket.
| baseUrl: "/playroom/", | ||
| webpackConfig: () => ({ | ||
| resolve: { | ||
| extensions: [".js", ".jsx", ".ts", ".tsx", ".css"], |
There was a problem hiding this comment.
Do we need .js* extensions?
| ], | ||
| }, | ||
| { | ||
| test: /\.(js|jsx|ts|tsx)$/, |
There was a problem hiding this comment.
Out of curiosity, do you know if there is any possibility of customizing the Playroom UI a little bit? Adding an orbit header, palette, etc.
Not critical of course.
| }, | ||
| }), | ||
| reactDocgenTypescriptConfig: { | ||
| // TODO: Disabling prop intellisense until we can fix the issue with correctly getting the props |
There was a problem hiding this comment.
Have we created a ticket about this?
mvidalgarcia
approved these changes
Jan 22, 2025
|
Kudos to all of you involved! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Playroom Integration
This PR adds Playroom integration to Orbit components. The setup includes:
Changes
Testing
Link to Devin run: https://app.devin.ai/sessions/7f5abe9df1824beb8cc2f5a28fab8529