feat(NavigationBar): allow for transparent background when at the top… #4542
+49
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinCsl
commented
Dec 5, 2024
| bottomStyle === "shadow" && "shadow-fixed", | ||
| bottomStyle === "border" && "border-cloud-normal border-b", | ||
| shown ? "translate-y-0" : "tb:-translate-y-1600 -translate-y-xxxl", // As defined on the const above | ||
| !isTransparentBg && bottomStyle === "shadow" && "shadow-fixed", |
There was a problem hiding this comment.
We only apply the existing bottomStyle logic when the background is not transparent.
RobinCsl
force-pushed
the
rcsl/navbar-transparent-at-top
branch
from
18a7fb8 to
6b370b4
Compare
Deploying orbit with
|
| Latest commit: |
60871c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79b0afd4.orbit.pages.dev |
| Branch Preview URL: | https://rcsl-navbar-transparent-at-t.orbit.pages.dev |
RobinCsl
force-pushed
the
rcsl/navbar-transparent-at-top
branch
from
6b370b4 to
b35a63b
Compare
|
Storybook staging is available at https://kiwicom-orbit-rcsl-navbar-transparent-at-top.surge.sh |
|
Size Change: +163 B (+0.04%) Total Size: 459 kB
ℹ️ View Unchanged
|
RobinCsl
force-pushed
the
rcsl/navbar-transparent-at-top
branch
2 times, most recently
from
1969ec3 to
820f88b
Compare
RobinCsl
force-pushed
the
rcsl/navbar-transparent-at-top
branch
from
820f88b to
4fca415
Compare
domihustinova
approved these changes
Dec 9, 2024
|
There's something odd about this 🤔 If I have Untitled.mov |
DSil
reviewed
Dec 10, 2024
| shown ? "translate-y-0" : "tb:-translate-y-1600 translate-y-[-52px]", // As defined on the const above | ||
| bottomStyle === "shadow" && "shadow-fixed", | ||
| bottomStyle === "border" && "border-cloud-normal border-b", | ||
| shown ? "translate-y-0" : "tb:-translate-y-1600 -translate-y-xxxl", // As defined on the const above |
There was a problem hiding this comment.
xxxl is deprecated, so we should keep the hardcoded value
There was a problem hiding this comment.
It was the auto-formatting that did this, I tried many times to bypass it and looks like I failed in my last push 😅
There was a problem hiding this comment.
We need to get rid of that long deprecated xxxl token asap 😌
RobinCsl
force-pushed
the
rcsl/navbar-transparent-at-top
branch
from
4fca415 to
9770931
Compare
I think something was possibly missing for the I noticed that before but somehow thought it was some Storybook oddity. Glad you pushed me to take another look :) |
|
The issue reported by Daniel now works fine, LGTM 👍 |
RobinCsl
force-pushed
the
rcsl/navbar-transparent-at-top
branch
from
9770931 to
d3943c9
Compare
|
@domihustinova I just fixed the conflicts and tried it again in Storybook and it seemed to work fine. |
… of the screen This was requested on Slack.
RobinCsl
force-pushed
the
rcsl/navbar-transparent-at-top
branch
from
d3943c9 to
60871c1
Compare
![callstackai[bot]](https://avatars.githubusercontent.com/in/1040204?s=60&v=4){kind=small}
| window.pageYOffset || | ||
| (document.documentElement && document.documentElement.scrollTop); | ||
| if (transparentBgAtTop) { | ||
| setTransparentBg(currentScrollPosition <= 0); |
There was a problem hiding this comment.
shouldn't == 0 be enough here?
There was a problem hiding this comment.
Never mind, it's possible 😄
src: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollTop#value
mvidalgarcia
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of the screen
This was requested on Slack.
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.tsHere's a preview of the change:
Screen.Recording.2024-12-05.at.15.15.57.mov
✨
Description by Callstackai
This PR introduces a new feature to the
NavigationBarcomponent, allowing for a transparent background when the navigation bar is at the top of the viewport.Diagrams of code changes
sequenceDiagram participant User participant NavigationBar participant Window Note over NavigationBar: Initialize with transparentBgAtTop prop alt transparentBgAtTop is true Window->>NavigationBar: Initial scroll position check NavigationBar->>NavigationBar: Set transparent bg if at top end User->>Window: Scrolls page Window->>NavigationBar: Scroll event alt transparentBgAtTop is true NavigationBar->>NavigationBar: Check scroll position alt scroll position <= 0 NavigationBar->>NavigationBar: Set background transparent else scroll position > 0 NavigationBar->>NavigationBar: Set background white end endFiles Changed
transparentBgAtTopto theNavigationBarstory.transparentBgAtTopprop.transparentBgAtTopprop in theNavigationBarcomponent.transparentBgAtTopprop.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.md. See list of supported languages.