update for some jupyter_client 7.0 API changes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- shell_channel.get_msg -> get_shell_msg - iopub_channel.get_msg -> get_iopub_msg this change represents updates to the jupyter_client API in version 7.0: https://jupyter-client.readthedocs.io/en/stable/migration.html
|
Unless I missed it, I recommend you mention somewhere that numpy and matplotlib are required for the tests! |
|
I reviewed the rest of the 7.0 API changes, and it looks like the ones I caught were the only ones that needed changing. I recommend you lock the jupyter_client package to a 7.0+ version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to install knitty this morning it did not work for me! I figured out that my issues were caused by the recent 7.0 update of the jupyter_client package, which changed the API a bit.
This PR contains the changes required to make my instance of knitty work again. I am not sure if I fully updated the package to jupyter_client 7.0, though I doubt there would be many I missed.
Thanks for this wonderful package, it is exactly what I've been looking for!