Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a render option to render the image as <figure> #458

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

JmPotato
Copy link
Contributor

Though #442 discussed a more common design to introduce this kind of customization to certain renderings, it's reasonable to me to have this option as a simple and direct solution to the <figure> demand.

This PR adds a new render option named figure_with_caption to do this.

Copy link
Owner

@kivikakk kivikakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thank you!

@kivikakk kivikakk merged commit e30dd1e into kivikakk:main Aug 23, 2024
20 checks passed
@JmPotato JmPotato deleted the figure_rendering_option branch August 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants