Add a multiline blockquote extension

[digitalmoksha]

Adds the ability to enclose multiple lines in a blockquote. Such as:

>>>
Paragraph one

Paragraph two
>>>

This is part of the GitLab Flavored Markdown (GLFM) specification, https://docs.gitlab.com/ee/user/markdown.html#multiline-blockquote

[digitalmoksha]

I still need to add an extension flag (right now it's fully hooked in).

And does it make sense make it a compile feature?

@kivikakk what do you think, would this be something that could be incorporated?

[kivikakk]

This looks awesome!

@digitalmoksha yes, I think we should definitely include this! I'd be inclined not to compile flag it, I think it's a handy option to have and there are increasingly Markdown dialects/input elements that support this syntax; no need to restrict it imo.

Let me know when you're done and I'll throw fuzzers at it for a while :)

[digitalmoksha]

there are increasingly Markdown dialects/input elements that support this syntax

Really, I wasn't aware of any. Do you have an example?

[kivikakk]

The one that comes to mind for me immediately is Discord: entering >>> at the start of a line will make the entire rest of the message fall under that blockquote. (There's no way to end it before the end of the message iirc. This behaviour only functions on mobile; on desktop the WYSIWYG editor takes over and produces the same effect.)

IIRC one or both of Slack and Mattermost also recognise this syntax, and I've seen people actually try it out elsewhere where it isn't supported!

[gjtorikian]

IIRC one or both of Slack and Mattermost also recognise this syntax

FWIW, Slack for sure supports it.

[digitalmoksha]

It looks Slack is the same as Discord, you can't turn off the block quote (at least I wasn't able to). You can't bracket it like a fenced code block.

[kivikakk]

Yep, indeed! They don't share that aspect of it, but it's similar and intuitive enough (imo).

[digitalmoksha]

I made the suggested changes and added the extension option multline-block-quotes

I think it's ready for final review.

[kivikakk]

LGTM! Thank you so much, @digitalmoksha! ❤️

I'm going to run fuzzing on this for a few hours, and merge when done.

[digitalmoksha]

Thanks for merging @kivikakk 🙇

[digitalmoksha]

@kivikakk when you have time, would it be possible to cut a new release?

[kivikakk]

Of course, will do so tonight!El 25 ene 2024, a la(s) 5:34, digitalMoksha ***@***.***> escribió: @kivikakk when you have time, would it be possible to cut a new release? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[kivikakk]

comrak 0.21.0 is now on crates.io! Thanks for your hard work, @digitalmoksha ❤️

[digitalmoksha]

Thank you @kivikakk! I've updated my dingus, it's working like a charm. https://gitlab-org.gitlab.io/ruby/gems/gitlab-glfm-markdown/