-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure exporter is created #5218
base: main
Are you sure you want to change the base?
Conversation
What are you trying to accomplish? |
I don't think the UI traces are actually getting exported/activated from UI in development. I can see them fine using the console exporter locally, including trace ids on page request logs... I was also able to see the actual exporter active in Tilt applying similar updates. |
Ok I recall this logger being super verbose so it might not be a great idea to enable it in anything but local. |
I think the problem could be the exporter type - it should be GRPC, as long as these are not originating from the client. If they are originating from the client, we'll need to setup a special otel ingress to receive them. |
This setup is only for server side to start with |
My theory here is that the check for the exporter type if failing with a js error b/c it wasn't set. Trying to fix the values the conditional is operating on first after which I'll also define a better default in flux.
Also wrapped the debug init in a flag I can set in flux if further debugging is needed...