Merge pull request #455 from kishikawakatsumi/bitmovin-engineering-fe…

…ature/fix-reported-line-numbers Bitmovin engineering feature/fix reported line numbers
kishikawakatsumi · Sep 26, 2022 · c908065 · c908065
2 parents e8dbbd5 + e0badee
commit c908065
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/report.ts b/src/report.ts
@@ -309,11 +309,13 @@ export class BuildLog {
                     const value = parseInt(pair[1])
                     switch (pair[0]) {
                       case 'StartingLineNumber': {
-                        startLine = value
+                        // StartingLineNumber is 0-based, but we need a 1-based value
+                        // see https://github.com/diogot/danger-xcode_summary/blob/master/lib/xcode_summary/plugin.rb#L207
+                        startLine = value + 1
                         break
                       }
                       case 'EndingLineNumber': {
-                        endLine = value
+                        endLine = value + 1
                         break
                       }
                       default:
@@ -378,11 +380,11 @@ export class BuildLog {
                   const value = parseInt(pair[1])
                   switch (pair[0]) {
                     case 'StartingLineNumber': {
-                      startLine = value
+                      startLine = value + 1
                       break
                     }
                     case 'EndingLineNumber': {
-                      endLine = value
+                      endLine = value + 1
                       break
                     }
                     default: