fix: logout redirect is not required

[coel]

Explain your changes

Log out redirect is not really required - the user will be directed to a generic log out screen if not provided. It also doesn't necessarily make sense for client credential flows and I see in the Svelte SDK it seems to use type assertions to avoid providing it: https://github.com/kinde-oss/kinde-sveltekit-sdk/blob/dbae249abe2e0c75913826b66a397afc25b6f548/src/lib/KindeSDK.ts#L19C3-L19C24

Checklist

• I have read the “Pull requests” section in the contributing guidelines.
• I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of logout redirection URLs in authentication flows to ensure more robust and error-free user sign-out experiences.
• Refactor
  • Updated the AuthCodeAbstract and ClientCredentials classes to handle logoutRedirectURL more efficiently.
  • Made the logoutRedirectURL property optional in the OAuth2FlowOptions interface.

[coderabbitai]

Walkthrough

The update enhances the SDK's OAuth2 flow handling by refining the logout redirect URL parameter management across multiple classes. It introduces optional handling for this parameter and improves method efficiency by removing unnecessary asynchronous operations. These changes aim to streamline authentication processes and increase the robustness of the SDK's configuration options.

Changes

Files	Change Summary
.../oauth2-flows/AuthCodeAbstract.ts .../oauth2-flows/ClientCredentials.ts	Adjusted handling of logoutRedirectURL with nullish coalescing and fallback mechanisms. Removed await from getSigningKey method in AuthCodeAbstract.
.../oauth2-flows/types.ts	Made logoutRedirectURL property optional in OAuth2FlowOptions interface.

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a863827 and 6e968b3.

Files selected for processing (3)

• lib/sdk/oauth2-flows/AuthCodeAbstract.ts (1 hunks)
• lib/sdk/oauth2-flows/ClientCredentials.ts (1 hunks)
• lib/sdk/oauth2-flows/types.ts (1 hunks)

Files skipped from review as they are similar to previous changes (3)

• lib/sdk/oauth2-flows/AuthCodeAbstract.ts
• lib/sdk/oauth2-flows/ClientCredentials.ts
• lib/sdk/oauth2-flows/types.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.