Merge pull request #31 from kinde-oss/leo/refresh_decode

fix: prevent trying to decode refresh token
kinde-oss · Nov 17, 2023 · 699fe0b · 699fe0b
2 parents d69ee34 + eb396a5
commit 699fe0b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/__tests__/sdk/oauth2-flows/ClientCredentials.spec.ts b/lib/__tests__/sdk/oauth2-flows/ClientCredentials.spec.ts
@@ -142,14 +142,14 @@ describe('ClientCredentials', () => {
     it('commits access token to memory, when a new one is fetched', async () => {
       const mockAccessToken = mocks.getMockAccessToken(clientConfig.authDomain);
       mocks.fetchClient.mockResolvedValue({
-        json: () => ({ access_token: mockAccessToken }),
+        json: () => ({ access_token: mockAccessToken.token }),
       });
 
       const client = new ClientCredentials(clientConfig);
       await client.getToken(sessionManager);
       expect(mocks.fetchClient).toHaveBeenCalledTimes(1);
       expect(await sessionManager.getSessionItem('access_token')).toBe(
-        mockAccessToken
+        mockAccessToken.token
       );
     });
   });

diff --git a/lib/sdk/utilities/token-utils.ts b/lib/sdk/utilities/token-utils.ts
@@ -37,11 +37,12 @@ export const commitTokenToMemory = async (
   token: string,
   type: TokenType
 ): Promise<void> => {
-  const tokenPayload = jwtDecode(token);
   await sessionManager.setSessionItem(type, token);
   if (type === 'access_token') {
+    const tokenPayload = jwtDecode(token);
     await sessionManager.setSessionItem('access_token_payload', tokenPayload);
   } else if (type === 'id_token') {
+    const tokenPayload = jwtDecode(token);
     await sessionManager.setSessionItem('id_token_payload', tokenPayload);
     await commitUserToMemoryFromToken(sessionManager, token);
   }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@kinde-oss/kinde-typescript-sdk",
-  "version": "2.2.4",
+  "version": "2.3.0",
   "description": "Kinde Typescript SDK",
   "main": "dist-cjs/index.js",
   "module": "dist/index.js",