Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support topologySpreadConstraints in Deployment config #308

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Jan 28, 2025

part of : kiali/kiali#5614

To quickly test:

  1. Build the charts: make build-helm-charts
  2. Set some topology spread constraints to see that it gets into the deployment yaml:
helm template -n istio-system \
  --show-only templates/deployment.yaml \
  --set deployment.topology_spread_constraints[0].maxSkew=1 \
  --set deployment.topology_spread_constraints[0].whenUnsatisfiable=DoNotSchedule \
  --set deployment.topology_spread_constraints[0].topologyKey=kubernetes.io/hostname \
  kiali-server \
  _output/charts/kiali-server-*.tgz
  1. See that the spec.topologySpreadConstraints yaml is in the yaml
  2. Now see that if you do not specify topology spread constraints, the yaml does not show anything:
helm template -n istio-system --show-only templates/deployment.yaml kiali-server _output/charts/kiali-server-*.tgz

@jmazzitelli jmazzitelli self-assigned this Jan 28, 2025
@jmazzitelli jmazzitelli added the requires operator PR Requires changes to the operator label Jan 28, 2025
@jshaughn jshaughn self-requested a review January 28, 2025 19:56
Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jmazzitelli jmazzitelli merged commit e072a1a into kiali:master Jan 28, 2025
1 check passed
@jmazzitelli jmazzitelli deleted the 5614-topo-spread-constraints branch January 28, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires operator PR Requires changes to the operator
Projects
Development

Successfully merging this pull request may close these issues.

2 participants