Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version to 22 #9417

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Update node version to 22 #9417

merged 2 commits into from
Dec 8, 2024

Conversation

gautamsi
Copy link
Member

@gautamsi gautamsi commented Dec 6, 2024

No description provided.

@dcousens
Copy link
Member

dcousens commented Dec 7, 2024

Can you update the examples/*/sandbox.config.json files too?

@gautamsi
Copy link
Member Author

gautamsi commented Dec 8, 2024

@dcousens have update version in sandbox but it seems codesandbox does not like this version, may have to change some config for supporting this nodejs version for codesandbox

@dcousens
Copy link
Member

dcousens commented Dec 8, 2024

@gautamsi what issue presents?

@dcousens dcousens merged commit 6616cd1 into keystonejs:main Dec 8, 2024
42 of 46 checks passed
@gautamsi gautamsi deleted the lts-22 branch December 8, 2024 08:31
@gautamsi
Copy link
Member Author

gautamsi commented Dec 8, 2024

see https://ci.codesandbox.io/status/keystonejs/keystone/pr/9417/builds/568305

Error: Invalid node version "22"

@dcousens
Copy link
Member

dcousens commented Dec 8, 2024

Following up in codesandbox/codesandbox-client#5865 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants