Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): disable early keyboard-loading when not feasible 🏠 #13039

Open
wants to merge 3 commits into
base: stable-17.0
Choose a base branch
from
Open

fix(android): disable early keyboard-loading when not feasible 🏠 #13039

wants to merge 3 commits into from

Conversation

jahorton
Copy link
Contributor

Cherry-pick-of: #13001

User Testing

TEST_ANDROID_GENERAL_USE: Do some simple tests with the Keyman for Android app, verifying that the keyboard acts normally. Just a few keystrokes should be fine.

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 24, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 24, 2025 •
edited
Loading

User Test Results

Test specification and instructions

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(android): disable early keyboard-loading when not feasible fix(android): disable early keyboard-loading when not feasible 🏠 Jan 24, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S20 milestone Jan 24, 2025
@dinakaranr
Copy link

Test Results

I tested this issue with the attached "17.0.334-alpha-test-13039" build(24/01/2025) on Android 14(Physical Device) and Android 13(Emulator). Here is my observation.

  • TEST_ANDROID_GENERAL_USE (passed):
  1. Downloaded the khmer_angkor.kmp file from this PR task.
  2. Installed the "Keyman-17.0.334.apk" file from this PR build.
  3. Open the Keyman app.
  4. Checked the "Enable Keyman as system-wide keyboard". Set the keyboard as the default keyboard box on the settings page.
  5. Installed the khmer_angkor, SIL_IPA, Tamil99 and gff_amharic.
  6. Verified that the keyman keyboards were installed successfully and worked with good keystrokes.
    It works well. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 24, 2025
darcywong00
darcywong00 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 darcywong00 approved these changes

@sgschantz sgschantz Awaiting requested review from sgschantz sgschantz is a code owner

Assignees
No one assigned
Labels
android/engine/ android/ fix has-user-test stable
Projects
Keyman
Status: No status
Milestone
A18S20
Development

Successfully merging this pull request may close these issues.
3 participants
@jahorton @dinakaranr @darcywong00