fix(windows): add api GetContext and TIPProcessKeyEx with IsTextSelected bool #13023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
Add the api calls that include the output bool isSelected, which is true if text is selected.
rc-swag
changed the base branch from
master
to
fix/windows/7870/add-is-text-selected-flag-api
mcdurdin
changed the title
mcdurdin
requested changes
Jan 24, 2025
| @@ -208,6 +209,7 @@ typedef struct tagKEYMAN64THREADDATA | |||
|
|
|||
| PKEYMANPROCESSOUTPUTFUNC TIPProcessOutput; | |||
| PKEYMANGETCONTEXTFUNC TIPGetContext; | |||
| PKEYMANGETCONTEXTISSELECTEDFUNC TIPGetContextEx; | |||
There was a problem hiding this comment.
These names should really match -- should be either:
Suggested change
| PKEYMANGETCONTEXTISSELECTEDFUNC TIPGetContextEx; | |
| PKEYMANGETCONTEXTISSELECTEDFUNC TIPGetContextIsSelected; |
or
Suggested change
| PKEYMANGETCONTEXTISSELECTEDFUNC TIPGetContextEx; | |
| PKEYMANGETCONTEXTEXFUNC TIPGetContextEx; |
Comment on lines
209
to
+215
| _hr = E_FAIL; // TODO: use S_FALSE -> this tells _KeymanProcessKeystroke to pass keystroke on | ||
| } | ||
|
|
||
| if (!Keyman32Interface::TIPProcessKeyEx(_wParam, _lParam, ExtKeymanProcessOutput, ExtKeymanGetContextIsSelected, _fUpdate, _fPreserved)) { | ||
| SendDebugMessage(L"TIPProcessKeyEx did not handle the keystroke"); | ||
| _hr = E_FAIL; // TODO: use S_FALSE -> this tells _KeymanProcessKeystroke to pass keystroke on | ||
| } |
There was a problem hiding this comment.
This code is puzzling to me -- why are you calling both TIPProcessKey and TIPProcessKeyEx? Shouldn't be either one or the other?
Test ResultsI tested this issue with the attached "18.0.177-alpha-test-13023" build(24/01/2025) on Windows 10 OS. Here is my observation.
|
keymanapp-test-bot
bot
removed
the
user-test-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as extension of #12649
This adds
GetContextExandTIPProcessKeyExAPI call to handle having a output bool parameter that is Bool is there is text selected.User Testing
TEST_DELETE_SELECTED_TEXT
Install the Keyman for Windows build artifact with this PR.
This test must be done with an application using the Text Services Framework (TSF). You cannot use
the Web version of Word. Use WordPad that comes installed with Windows 10 and Windows 11.
Install a Keyman keyboard like EuroLatin
mySchoolSchooland type backspaceExpected result
mySome regression tests.
TEST_BACKSPACE_NO_SELECTION
Install a Keyman keyboard like euro_latin
mySchoolExpected result
mySchooTEST_SELECTION_TYPE_CHAR
mySchoolSchooland type tExpected result
myt