Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass campaign url params #84

Merged
merged 7 commits into from
Oct 30, 2024
Merged

pass campaign url params #84

merged 7 commits into from
Oct 30, 2024

Conversation

felicio
Copy link
Contributor

@felicio felicio commented Oct 29, 2024

package.json Show resolved Hide resolved
@jkbktl
Copy link

jkbktl commented Oct 29, 2024

It seems to be working great on landing page (i.e. homepage), but when you redirect to different page (i.e. faq), it disappears. Are we okay with that like this?

@felicio felicio requested a review from marcelines October 29, 2024 12:10
@felicio
Copy link
Contributor Author

felicio commented Oct 29, 2024

It seems to be working great on landing page (i.e. homepage), but when you redirect to different page (i.e. faq), it disappears. Are we okay with that like this?

fe7d0a8

@felicio felicio requested review from marcelines and jkbktl and removed request for jkbktl October 29, 2024 12:13
@felicio
Copy link
Contributor Author

felicio commented Oct 30, 2024

@guylouis @bitgamma could one of you merge this please?

image

@felicio
Copy link
Contributor Author

felicio commented Oct 30, 2024

@guylouis @bitgamma could one of you merge this please?

image

@jakubgs could you, please? And deploy it to prod as well?

@bitgamma bitgamma merged commit acf6b25 into develop Oct 30, 2024
@bitgamma bitgamma deleted the campaign-cta branch October 30, 2024 13:48
@jakubgs
Copy link
Contributor

jakubgs commented Oct 30, 2024

Did you verify via https://dev.keycard.tech/ site that the version in develop works as expected?

@jakubgs
Copy link
Contributor

jakubgs commented Oct 30, 2024

Guys, have you heard about squashing commits?

image

This is unsightly.

@felicio
Copy link
Contributor Author

felicio commented Oct 30, 2024

Did you verify via https://dev.keycard.tech/ site that the version in develop works as expected?

No. As you pointed out in DMs, dev wasn't being deployed, only prod was. Which worked as expected.

@felicio
Copy link
Contributor Author

felicio commented Oct 30, 2024

squashing commits?

Not a maintainer of this repo, just helped out. Can you set rule accordingly in repo's settings?

@jakubgs
Copy link
Contributor

jakubgs commented Oct 30, 2024

I think rebase merging is fine a long as you keep your PR commits tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants