remove redundant flag boolean option

kevinfalting · Jan 6, 2025 · e143bd8 · e143bd8
1 parent 8d329ed
commit e143bd8
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/structconf.go b/structconf.go
@@ -26,7 +26,7 @@ func Parse(ctx context.Context, cfg any, optionFuncs ...optionFunc) error {
 		confhandler.EnvironmentVariable{}.Handle,
 	}
 
-	if opt.useFlags {
+	if opt.flagSet != nil {
 		flagHandler := confhandler.NewFlag(opt.flagSet)
 		if err := flagHandler.DefineFlags(fields); err != nil {
 			return err
@@ -52,8 +52,7 @@ func Parse(ctx context.Context, cfg any, optionFuncs ...optionFunc) error {
 }
 
 type option struct {
-	useFlags bool
-	flagSet  *flag.FlagSet
+	flagSet *flag.FlagSet
 }
 
 type optionFunc func(opt *option)
@@ -63,7 +62,6 @@ type optionFunc func(opt *option)
 // the stdlib flagset.
 func WithFlagSet(fset *flag.FlagSet) optionFunc {
 	return func(opt *option) {
-		opt.useFlags = true
 		opt.flagSet = fset
 	}
 }