Allow setting legend names when multiple series values are used in an Indicator #382 #385
Conversation
| @@ -105,6 +105,10 @@ def I(self, # noqa: E741, E743 | |||
| If `scatter` is `True`, the plotted indicator marker will be a | |||
| circle instead of a connected line segment (default). | |||
|
|
|||
| `legends` can be list or array of string values to represent | |||
| legends on your indicator chart. By default it's set to None, | |||
| and `name` is used as legends. | |||
There was a problem hiding this comment.
Why don't we simply reuse name= to accept a list of name values?
There was a problem hiding this comment.
@kernc I didn't use it because below line in _plotting.py expects name to be a single value and is being used while storing the source that is being passed in to customJS callback.
backtesting.py/backtesting/_plotting.py
Line 528 in 0a76e96
I think we can't treat it the same way as we do with color, as the scope of color is limited to plotting the indicator. But name is used as a key in other places to determine the auto scale Y axis range. Let me know, if you think otherwise. We can discuss further.
There was a problem hiding this comment.
@kernc did you get a chance to look at this?
There was a problem hiding this comment.
I am pretty sure, it should be possible to reuse name=, since color= is used in the same fashion. For instance here is an example how to set multiple colors.
Having two arguments to set one thing is very confusing from the API perspective.
There was a problem hiding this comment.
@ivaigult Can you try and let me know. My first attempt was to pass array to name but it didn't work. I already mentioned my reasoning in previous comment. If you can make it work with name that would be great :)
kernc
force-pushed
the
master
branch
3 times, most recently
from
7fd493d to
e7981c7
Compare
kernc
force-pushed
the
master
branch
9 times, most recently
from
60eff81 to
109c352
Compare
Fixes #382