sender unregisters its own metrics

kentik · Jan 20, 2024 · a1264ce · a1264ce
1 parent 4515751
commit a1264ce
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/lib_test.go b/lib_test.go
@@ -89,31 +89,26 @@ func TestNewSenderWithDeviceNameLeaks(t *testing.T) {
 	assert.NoError(err)
 	assert.NotNil(s)
 	s.Stop(time.Second)
-	s.Metrics.Unregister()
 
 	s, err = libkflow.NewSenderWithDeviceName(device.Name, errors, config)
 	assert.NoError(err)
 	assert.NotNil(s)
 	s.Stop(time.Second)
-	s.Metrics.Unregister()
 
 	s, err = libkflow.NewSenderWithDeviceName(device.Name, errors, config)
 	assert.NoError(err)
 	assert.NotNil(s)
 	s.Stop(time.Second)
-	s.Metrics.Unregister()
 
 	s, err = libkflow.NewSenderWithDeviceName(device.Name, errors, config)
 	assert.NoError(err)
 	assert.NotNil(s)
 	s.Stop(time.Second)
-	s.Metrics.Unregister()
 
 	s, err = libkflow.NewSenderWithDeviceName(device.Name, errors, config)
 	assert.NoError(err)
 	assert.NotNil(s)
 	s.Stop(time.Second)
-	s.Metrics.Unregister()
 
 	server.Close()
 

diff --git a/send.go b/send.go
@@ -195,6 +195,7 @@ func (s *Sender) monitor() {
 			s.workers.Wait()
 			s.ticker.Stop()
 			s.tickerCancelFunc()
+			s.Metrics.Unregister()
 			s.exit <- struct{}{}
 			log.Debugf("sender stopped")
 			return