OS upgrade: v0.13.3 #465
Merged
OS upgrade: v0.13.3 #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update cairo-lang to v0.13.3 * expect Starknet v0.13.3 version * set_state_updates_start & set_compressed_start * update deserialize OS output * hint implementation: set_n_updates_small * disable test until we get a reference PIE with the new OS version * set full_output for integration tests * deserialize output fix tests * update sequencer address * fix CI: bump cairo-lang to v0.13.3 * clippy * bump cairo-lang * fix tests * fix use_kzg_da global variable * add hint test * fix is_s_updates_small * add tests for set_compressed_start and set_state_updates_start * fix StarknetGeneralConfig * add test with reference PIEs
* feat: add the log2_ceil hint * simplify log2 function * clean up unimplemented.rs --------- Co-authored-by: whichqua <[email protected]>
* feat: add dict manager and get offset hints for v0.13.3 * use TOTAL_N_BUCKETS from constants * handle error * rename dict to compression * compression constants * change unimplemented.rs description * clippy --------- Co-authored-by: whichqua <[email protected]>
whichqua
requested changes
Jan 17, 2025
* compression hint * set_decompressed_dst hint * use log2 from math.rs * add test get_n_elms_per_felt * fix: handle `full_output` compression correctly (#461) * fix: handle kzg compression correctly * lint: clippy and fmt * fix: replace unwrap with expect for get_index * add: docs and tests for the compression module * remove unused constant --------- Co-authored-by: Geoffrey Mureithi <[email protected]>
* feat: decompress the output to state diff * chore: replace unwraps with expect
notlesh
approved these changes
Jan 22, 2025
whichqua
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS upgrade to
v0.13.3: This PR enables SNOS to process blocks from the latests OS version.The implementation was split in 2 big features: minimal changes to process new blocks and compression related function.
First part consists of: #453
Second part consists of: #454, #455, #464 and #466
Since there were some changes in the serialization step from the OS, the reference PIE that was used for testing before, was replaced and some extra PIEs were added.
The PIEs from November and December provided by Starkware were compared with the ones that generates SNOS and all of them match.
Due to a time constrain, a random sample from all the provided PIEs were tested:
PIEs from November 2024: 12,819 ✅
PIEs from December 2024: 2,528 ✅
Issue Number: N/A
Type
Description
Breaking changes?