Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: reorganize Tests crate #59

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

TAdev0
Copy link
Collaborator

@TAdev0 TAdev0 commented Aug 12, 2024

This PR reorganizes Tests crate because all files inside it except tests.cairo where not compiled when running scarb test.

Now everything compiles, but the scripts to generate will still need improvements

@TAdev0 TAdev0 requested review from m-kus and maciejka as code owners August 12, 2024 12:49
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 2:28pm

Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/utils.cairo Outdated Show resolved Hide resolved
Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add get_blocks.sh script: #52 (comment)

@TAdev0
Copy link
Collaborator Author

TAdev0 commented Aug 12, 2024

@maciejka its all good.

I tested it locally, it returns blocks with valid syntax/organization that compile without modification.

Is just missing the comment which will be deleted each time we regenerate the blocks. Might need a bit of help on that, dont know how to do that..

@TAdev0
Copy link
Collaborator Author

TAdev0 commented Aug 12, 2024

tristan@Tristans-MacBook-Pro raito % ./scripts/data/get_blocks.sh


Getting block: 000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f
Getting block: 00000000d1145790a8694403d4063f323d499e655c83426834d4ce2f8dd4a2ee
All blocks retrieved successfully.

@maciejka
Copy link
Collaborator

@maciejka its all good.

I tested it locally, it returns blocks with valid syntax/organization that compile without modification.

Is just missing the comment which will be deleted each time we regenerate the blocks. Might need a bit of help on that, dont know how to do that..

Just add comments to the get_blocks.sh for now.

@TAdev0
Copy link
Collaborator Author

TAdev0 commented Aug 12, 2024

@maciejka done

@maciejka
Copy link
Collaborator

@maciejka its all good.
I tested it locally, it returns blocks with valid syntax/organization that compile without modification.
Is just missing the comment which will be deleted each time we regenerate the blocks. Might need a bit of help on that, dont know how to do that..

Just add comments to the get_blocks.sh for now.

It is already there. Nice.

@maciejka maciejka merged commit 72c5c74 into keep-starknet-strange:main Aug 12, 2024
5 checks passed
@TAdev0 TAdev0 deleted the improve_tests_crate branch August 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants