-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: reorganize Tests crate #59
[chore]: reorganize Tests crate #59
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add get_blocks.sh script: #52 (comment)
@maciejka its all good. I tested it locally, it returns blocks with valid syntax/organization that compile without modification. Is just missing the comment which will be deleted each time we regenerate the blocks. Might need a bit of help on that, dont know how to do that.. |
|
Just add comments to the get_blocks.sh for now. |
@maciejka done |
It is already there. Nice. |
This PR reorganizes Tests crate because all files inside it except tests.cairo where not compiled when running
scarb test
.Now everything compiles, but the scripts to generate will still need improvements