Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute merkle root implementation #43

Merged
merged 9 commits into from
Aug 9, 2024
Merged

compute merkle root implementation #43

merged 9 commits into from
Aug 9, 2024

Conversation

mubarak23
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 0:07am

@mubarak23
Copy link
Contributor Author

@maciejka here is the PR with the unit test for the function

maciejka
maciejka requested changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please turn this to a pr into pr #43.
You need to change this line:
image

src/merkle_tree.cairo Outdated Show resolved Hide resolved
src/merkle_tree.cairo Outdated Show resolved Hide resolved
@mubarak23 mubarak23 changed the base branch from main to mk/merkle_tree August 8, 2024 12:56
@mubarak23 mubarak23 requested a review from maciejka August 8, 2024 14:05
maciejka
maciejka reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but fix compilation errors.

@mubarak23
Copy link
Contributor Author

Ok, but fix compilation errors.

that was what i just push

maciejka
maciejka reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests:
image

@mubarak23
Copy link
Contributor Author

Fix tests: image

ok

@maciejka
Copy link
Collaborator

maciejka commented Aug 8, 2024

Fix tests: image

ok

@mubarak23

Please after pushing your commits check on github if all checks pass:
image

You can also run it locally before pushing:

scrab build
scarb test
scarb fmt

@mubarak23
Copy link
Contributor Author

running scarb build keep returning some error, pointing to this function,

double_sha256

currently on it

@maciejka maciejka merged commit f305ce9 into keep-starknet-strange:mk/merkle_tree Aug 9, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejka maciejka maciejka requested changes

@m-kus m-kus Awaiting requested review from m-kus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mubarak23 @maciejka