Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of BIP340 verification #8

Merged
merged 9 commits into from
May 3, 2024
Merged

Implementation of BIP340 verification #8

merged 9 commits into from
May 3, 2024

Conversation

maciejka
Copy link
Collaborator

@maciejka maciejka commented May 1, 2024

Requires scarb nightly.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 2:49pm
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 2:49pm

Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when Rust doc style comments are added

onchain/src/bip340.cairo Show resolved Hide resolved
onchain/src/bip340.cairo Show resolved Hide resolved
onchain/src/bip340.cairo Outdated Show resolved Hide resolved
onchain/src/bip340.cairo Show resolved Hide resolved
@maciejka maciejka requested review from 0xLucqs May 3, 2024 13:59
onchain/src/bip340.cairo Outdated Show resolved Hide resolved
onchain/src/bip340.cairo Outdated Show resolved Hide resolved
onchain/src/bip340.cairo Outdated Show resolved Hide resolved
@AbdelStark AbdelStark merged commit 967c178 into main May 3, 2024
7 checks passed
@AbdelStark AbdelStark deleted the mk/bip340 branch May 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants