Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore route cleanup #63

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

Xaxxoo
Copy link
Contributor

@Xaxxoo Xaxxoo commented Apr 19, 2024

  • issue #
  • follows contribution guide
  • code change includes tests
  • breaking change

It's a house* chore I did and cleaned up the backend routes from having camel casing to snake cased but with words separated with a -

@Xaxxoo Xaxxoo requested a review from b-j-roberts as a code owner April 19, 2024 14:24
@b-j-roberts
Copy link
Contributor

Looks good, I'll take a deeper look and test after merging the other PR. Since this is based on the other PR, some issues may need to be resolved.
Typically its better to do each PR based on main instead of other branches to avoid issues like that.

@Xaxxoo
Copy link
Contributor Author

Xaxxoo commented Apr 19, 2024

Looks good, I'll take a deeper look and test after merging the other PR. Since this is based on the other PR, some issues may need to be resolved. Typically its better to do each PR based on main instead of other branches to avoid issues like that.

I can do that on the main if you permit me.

@b-j-roberts
Copy link
Contributor

I can do that on the main if you permit me.

I'm not sure what you mean, but it should be good to rebase now if you can.

@Xaxxoo Xaxxoo force-pushed the chore-route-cleanup branch from fbb4889 to 07cb9c6 Compare April 26, 2024 08:12
@b-j-roberts b-j-roberts merged commit 8d44c71 into keep-starknet-strange:main Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants