Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Deposit reward when adding a new template #41

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Apr 14, 2024

Closes #30

@b-j-roberts i had issues with conflicts, i opened a new PR.

I added tests for depositing reward.
Tell me if this is ok for you

@TAdev0 TAdev0 requested a review from b-j-roberts as a code owner April 14, 2024 12:09
@TAdev0
Copy link
Contributor Author

TAdev0 commented Apr 14, 2024

@b-j-roberts ready for review

Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things.

onchain/src/templates/component.cairo Outdated Show resolved Hide resolved
onchain/src/templates/component.cairo Outdated Show resolved Hide resolved
@b-j-roberts
Copy link
Contributor

General tip: You should be able to do a force push after resolving conflicts, which would prevent you from needing to open a new PR. Something like git push ... -f

@TAdev0
Copy link
Contributor Author

TAdev0 commented Apr 15, 2024

@b-j-roberts yeah I know , I just had issues when rebasing. Thanks !

@TAdev0
Copy link
Contributor Author

TAdev0 commented Apr 15, 2024

@b-j-roberts PR updated !

@b-j-roberts b-j-roberts merged commit e04b0eb into keep-starknet-strange:main Apr 15, 2024
3 checks passed
@b-j-roberts
Copy link
Contributor

Nice work! Thanks for quickly resolving issues.

@TAdev0
Copy link
Contributor Author

TAdev0 commented Apr 15, 2024

@b-j-roberts if you have any other issue, i'm available :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Template ERC20 rewards deposit
2 participants