-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Deposit reward when adding a new template #41
[feat] Deposit reward when adding a new template #41
Conversation
@b-j-roberts ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things.
General tip: You should be able to do a force push after resolving conflicts, which would prevent you from needing to open a new PR. Something like |
@b-j-roberts yeah I know , I just had issues when rebasing. Thanks ! |
@b-j-roberts PR updated ! |
Nice work! Thanks for quickly resolving issues. |
@b-j-roberts if you have any other issue, i'm available :) |
Closes #30
@b-j-roberts i had issues with conflicts, i opened a new PR.
I added tests for depositing reward.
Tell me if this is ok for you