Fix tests #200
Merged
Fix tests #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t use the shared NSURLSession since it might get wrapped by more than one OCMockObject if the tests misbehave. Fix a few asynchronous tests that weren’t waiting for async code to complete.
masojus
approved these changes
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly reference dependency injected version of KIODBStore and reference self within KIONetwork.
Fix another false positive DB failure which would cause #183 to be observed more frequently, since trying to get a non-existent query from the db would be handled as a db error and close the db.
Fix a few async tests that weren't waiting for async code to complete.
Likely to fix #192.